feat: initialize this project #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eddyxu
commented
Nov 30, 2024
•
eddyxu
commented
- Setting up CI
- Get DX working
- InMemoryCache
| log = "~0.4" | ||
| moka = { version = "~0.12", features = ["future"] } | ||
| num_cpus = "1.16" | ||
| object_store = "~0.11" |
There was a problem hiding this comment.
this is 0.11,<0.12? Can we use more than that?
| [dependencies] | ||
| async-trait = "0.1" | ||
| bytes = "~1.9" | ||
| futures = "0.3" |
| categories = ["caching"] | ||
|
|
||
| [dependencies] | ||
| async-trait = "0.1" |
| # ocra | ||
| OCRA: Object-store Cache in Rust for All | ||
| # OCRA | ||
|
|
| use crate::{paging::PageCache, Error, Result}; | ||
|
|
||
| /// Default memory page size is 8 MB | ||
| pub const DEFAULT_PAGE_SIZE: usize = 8 * 1024 * 1024; |
There was a problem hiding this comment.
let's make this 16KiB? 8MIB is kinda huge
|
|
||
| /// Default memory page size is 8 MB | ||
| pub const DEFAULT_PAGE_SIZE: usize = 8 * 1024 * 1024; | ||
| const DEFAULT_TIME_TO_LIVE: Duration = Duration::from_secs(60 * 30); // 30 minutes |
There was a problem hiding this comment.
default time to idle makes more sense since we are CoW.
There was a problem hiding this comment.
Oh this was time to idle. Forgot to rename it.
| /// [PageCache] trait. | ||
| /// | ||
| /// Caching fixed-size pages. Each page has a unique ID. | ||
| #[async_trait] |
There was a problem hiding this comment.
do we need dynamic dispatching here? can we do with just static dispatch with -> impl Future<...>
There was a problem hiding this comment.
Need some rust help then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.